Add short-circuit rule for Contributor nominations. #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Matthews <[email protected]>
Manishearth
approved these changes
Sep 6, 2025
mrego
reviewed
Sep 29, 2025
| ### Nomination | ||
|
|
||
| A **Maintainer** requests the addition of a new **Contributor** in the private *Maintainers* channel in Zulip, listing the number of nontrival contributions by that person. A person may also request that a **Maintainer** nominates them and vouch for them. If no objections are raised within one week, the person is added to the **Contributors** team. | ||
| A **Maintainer** requests the addition of a new **Contributor** in the private *Maintainers* channel in Zulip, listing the number of nontrival contributions by that person. A person may also request that a **Maintainer** nominates them and vouch for them. If no objections are raised within one week, the person is added to the **Contributors** team. Additionally, if four other maintainers express support before the week has elapsed then there is no need to wait out the remaining time. |
There was a problem hiding this comment.
We have discussed about this in the TSC call today, it seems it'd be nice to add a minimum of 1 or 2 days of waiting time before we can make someone a contributor, in case someone has any concern to raise. Otherwise a new contributor could be approved in a few hours, without allowing any chance for someone to say anything about that person.
Would you be fine adding something like that to the new proposed text?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Contributor role has lower stakes than a Maintainer role, and nominations often receive lots of support very quickly. We should set a threshold for a nomination having enough support that we don't need to wait the full week.